This paper deals with reforms in English second language teaching in the People's Republic of China since the mid-1980s, with specific reference to Shanghai, which has been in the forefront of these reforms, examining important developments in curriculum policy, syllabus design, textbook production, examinations and research.